Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setting of read only fields and include deleted address spaces when assigning new address spaces #3714

Merged
merged 18 commits into from
Nov 16, 2023

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Sep 20, 2023

Resolves #3691

How is this addressed

  • Fixed iteration through schema to set read only properties
  • Exlplicitly set fields to updatable in templates
  • Moduified IP address assignment and validation to reuse those in deleted workspaces.

@marrobi marrobi marked this pull request as ready for review September 20, 2023 21:01
@marrobi marrobi marked this pull request as draft September 20, 2023 21:01
@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Unit Test Results

582 tests   582 ✔️  6s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 7b6bf35.

♻️ This comment has been updated with latest results.

@marrobi
Copy link
Member Author

marrobi commented Oct 3, 2023

/test-extended

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/6393206064 (with refid fdb1129a)

(in response to this comment from @marrobi)

@marrobi marrobi marked this pull request as ready for review October 3, 2023 12:51
@marrobi marrobi enabled auto-merge (squash) October 16, 2023 11:26
@marrobi marrobi requested a review from damoodamoo October 25, 2023 07:16
@marrobi
Copy link
Member Author

marrobi commented Nov 16, 2023

/test-extended

Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/6892211935 (with refid fdb1129a)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 7e8c5f7 into microsoft:main Nov 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot update workspace with custom address space
2 participants