Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network tags and depreciated TF for Azure ML. #4246

Merged
merged 3 commits into from
Jan 5, 2025

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Jan 2, 2025

Enhance Azure ML service configuration by updating the depreciated terraform and fixing network tag references. Update the changelog to reflect these changes.

Fixes #4151 and #3786

Copy link

github-actions bot commented Jan 2, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 3d29001.

♻️ This comment has been updated with latest results.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 4 changed files in this pull request and generated 1 comment.

Files not reviewed (3)
  • templates/workspace_services/azureml/terraform/main.tf: Language not supported
  • templates/workspace_services/azureml/terraform/network.tf: Language not supported
  • templates/workspace_services/azureml/terraform/outputs.tf: Language not supported

CHANGELOG.md Outdated Show resolved Hide resolved
@marrobi marrobi enabled auto-merge (squash) January 2, 2025 19:24
Co-authored-by: Copilot <[email protected]>
@marrobi marrobi requested a review from SvenAelterman January 3, 2025 10:33
@marrobi
Copy link
Member Author

marrobi commented Jan 3, 2025

/test-force-approve

Tested here - #4151 (comment) and not in CI.

Copy link

github-actions bot commented Jan 3, 2025

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 3d29001)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 5f27bae into microsoft:main Jan 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to deploy a 'Compute Instance' User Resource to a Workspace AML Service
3 participants