bugfix replace-output-directory #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjclark
reviewed
Feb 24, 2025
| output_dir="/".join( | ||
| self.stage_input_dirs[stage_type].split("/")[:-1] | ||
| ) | ||
| + "/output", |
There was a problem hiding this comment.
For clarity, here I would do:
output_dir = os.path.join(self.stage_input_dirs[stage_type], "output")
fjclark
reviewed
Feb 24, 2025
| if leg.leg_type == a3.LegType.BOUND: | ||
| expected_output_dir = "output".join( | ||
| stage.input_dir.rsplit("input", 1) | ||
| ) |
There was a problem hiding this comment.
Please use os.path.join. Thanks!
fjclark
reviewed
Feb 24, 2025
| @@ -348,6 +349,38 @@ def setup_calc(mock_run_process): | |||
| setup_calc.setup(bound_leg_sysprep_config=cfg, free_leg_sysprep_config=cfg) | |||
| yield setup_calc | |||
|
|
|||
| @pytest.fixture | |||
| def setup_calc_with_input_path(self, setup_calc): | |||
There was a problem hiding this comment.
Please just change all of these tmp dirs to used "temp_input_" - this will reduce duplication and speed things up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure only the last part of the path is changed.
input_calc/bound/inputwould get replaced withinput_calc/bound/output, rather thanoutput_calc/bound/output.Close #34.
Status
Could you please review @fjclark