Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leg replaces "input" with "output" in any part of calculations path #34

Open
fjclark opened this issue Feb 19, 2025 · 0 comments · May be fixed by #37
Open

Leg replaces "input" with "output" in any part of calculations path #34

fjclark opened this issue Feb 19, 2025 · 0 comments · May be fixed by #37
Assignees

Comments

@fjclark
Copy link
Collaborator

fjclark commented Feb 19, 2025

e.g. input_calc/bound/input... would get replaced with output_calc/bound/output, rather than the desired input_calc/bound/output

This is due to

output_dir=self.stage_input_dirs[stage_type].replace(
. We should update this so that only the last part of the path is changed.

@Roy-Haolin-Du please could you fix this?

Stages

  • Create branch e.q. bugfix-...
  • Fix bug
  • Write test which fails before bugfix and passes afterwards
  • Add to changelog
  • Format with ruff
  • Bump version number in _version.py to create patch release (e.g. 0.0.1 to 0.0.2)
  • Create PR
  • Merge PR once reviewed
  • Push new version git tag
  • Release new version on GitHub

Thanks!

@Roy-Haolin-Du Roy-Haolin-Du self-assigned this Feb 19, 2025
@Roy-Haolin-Du Roy-Haolin-Du linked a pull request Feb 24, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants