#303 Add scroll bar support to dropdown menus on dialogs, to prevent …

…dropdowns with many items overflowing off the bottom of the Git Graph View.
mhutchie · May 7, 2020 · 24abe53 · 24abe53
1 parent c36023d
commit 24abe53
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/web/dialog.ts b/web/dialog.ts
@@ -441,6 +441,7 @@ class CustomSelect {
 				optionsElem.style.top = (currentElemRect.top - dialogElemRect.top + currentElemRect.height - 2) + 'px';
 				optionsElem.style.left = (currentElemRect.left - dialogElemRect.left - 1) + 'px';
 				optionsElem.style.width = currentElemRect.width + 'px';
+				optionsElem.style.maxHeight = Math.max(document.body.clientHeight - currentElemRect.top - currentElemRect.height - 2, 50) + 'px';
 				if (this.optionsElem === null) {
 					optionsElem.className = 'customSelectOptions';
 					this.optionsElem = optionsElem;

diff --git a/web/styles/dialog.css b/web/styles/dialog.css
@@ -241,6 +241,7 @@
 	border-radius:0 0 4px 4px;
 	z-index:42;
 	text-align:left;
+	overflow-y:auto;
 }
 
 .customSelectOption{