Adding support for namespaces and clashing names in skin io #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a function to handle namespaces ( : ) and clashing names using full names ( | ) by replacing those characters with ones that Windows supports by default.
aurorafreir
changed the title
|
Thanks for the PR @CatAndDogSoup I will check it ASAP |
|
@CatAndDogSoup do you know if this approach is only working on windows? have you tried it with Mac or Linux? |
This call was causing problems when calling Import Skin from the UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
( as a possible fix for #172)
Adds a function to handle namespaces ( : ) and clashing names using full names ( | ) by replacing those characters with ones that Windows supports by default.
This is a bit of a gross approach, and maybe using a directory structure to handle it would be better, but this is an approach we're using and fixes all our name clash issues