Implement Upkeep::start_pinned API
#93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gootorov
commented
Oct 30, 2023
| @@ -58,12 +56,15 @@ pub struct Handle { | |||
| } | |||
|
|
|||
| /// Errors thrown during the creation/spawning of the upkeep thread. | |||
| #[non_exhaustive] | |||
There was a problem hiding this comment.
Note: adding #[non_exhaustive] is a breaking change (as is adding a new error variant), but allows adding more error variants in the future without breaking changes. MSRV for #[non_exhaustive] is 1.40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented via the core_affinity_rs library, which includes support for all platforms
quantatargets, with the exception of iOS. iOS users of this API would get a runtime error when attempting to start a pinnedUpkeepthread.Closes #92