Skip to content

Commit

Permalink
Drop old collector.prototyp implementation
Browse files Browse the repository at this point in the history
It's because old implementation does not satisfy latest tests and we have
modern implementation on prototpes. Old one is quick but this speed is
a result of less functionality, not the different approach.
  • Loading branch information
tshemsedinov committed Jun 16, 2019
1 parent 85509e9 commit f79188e
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 157 deletions.
134 changes: 0 additions & 134 deletions lib/collector.prototype.js

This file was deleted.

4 changes: 2 additions & 2 deletions tests/load/collect.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const COUNT = 1000000;
const benchmark = require('./benchmark.js');
const metasync = require('../../lib/collector.js');

const CollectPrototype = done => {
const Collect = done => {
const dc = metasync.collect(6);
dc.done(done);
let i = 0;
Expand All @@ -17,4 +17,4 @@ const CollectPrototype = done => {
setImmediate(() => dc.pick('6th', 'key' + ++i * 2));
};

benchmark.do(COUNT, [CollectPrototype]);
benchmark.do(COUNT, [Collect]);
20 changes: 0 additions & 20 deletions tests/load/collect.prototype.js

This file was deleted.

1 change: 0 additions & 1 deletion tests/load/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,4 @@ echo
echo Collector: 1mnl
node tests/load/collect.js
node tests/load/collect.class.js
node tests/load/collect.prototype.js
node tests/load/collect.functor.js

0 comments on commit f79188e

Please sign in to comment.