Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud profile version classification dates #9

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

Gerrit91
Copy link

@Gerrit91 Gerrit91 commented Dec 3, 2024

This is just a draft.

pkg/apis/core/validation/cloudprofile.go Outdated Show resolved Hide resolved
pkg/apis/core/validation/utils.go Outdated Show resolved Hide resolved
pkg/apis/core/validation/utils.go Outdated Show resolved Hide resolved
pkg/apis/core/validation/utils.go Outdated Show resolved Hide resolved
pkg/apis/core/validation/utils.go Outdated Show resolved Hide resolved
@vknabel
Copy link

vknabel commented Dec 6, 2024

Todo:

@vknabel vknabel force-pushed the cloud-profile-version-classification-dates branch from d198d0e to eb274c0 Compare January 7, 2025 10:48
@LucaBernstein LucaBernstein force-pushed the cloud-profile-version-classification-dates branch from eb274c0 to 2fffd28 Compare January 7, 2025 16:10
@vknabel vknabel force-pushed the cloud-profile-version-classification-dates branch from 2fffd28 to a78273f Compare January 8, 2025 08:44
gardener-ci-robot and others added 24 commits January 8, 2025 13:24
* Graduate `ShootForceDeletion` to GA

* Correct gardener version

* Fix test
There is only one remaining repository (considering default branches
only) in github.com/gardener organisation that features a file
`_images.tpl`:
  https://github.com/gardener/gardener-extension-provider-aws

However, said repository no longer seems to vendor gardener/gardener's
copy of component_descriptor script. Rm unused codepath as cleanup (will
help migrating from Concourse-Pipeline-Template).
…untime (gardener#11113)

* Use role 'garden-cert' for wildcard TLS certificate used for Garden runtime

* address review feedback
…dPredicate` and `dnsrecord` controller. (gardener#11123)

* Ignore non-shoot namespaces in shootNotFailedPredicate and dnsrecord controller

* Avoid calling GetCluster for dnsrecord and extension controllers if not garden namespace

* fix test description

Co-authored-by: Marc Vornetran <[email protected]>

* refactoring to address review feedback

* address review feedback: use shared IsShootNamespace method

---------

Co-authored-by: Marc Vornetran <[email protected]>
In the "seed is garden" case, the `VPAEvictionRequirements` controller is responsible for shoot namespaces as well.
Hence, it needs permissions to update/patch VPA resources in those namespaces.
Co-authored-by: Gerrit <[email protected]>
Co-authored-by: Claus-Theodor Riegg <[email protected]>
Co-authored-by: Luca Bernstein <[email protected]>
@vknabel vknabel force-pushed the cloud-profile-version-classification-dates branch from e2b4166 to 264d8f9 Compare January 13, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants