forked from gardener/gardener
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud profile version classification dates #9
Draft
Gerrit91
wants to merge
26
commits into
master
Choose a base branch
from
cloud-profile-version-classification-dates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerrit91
commented
Dec 3, 2024
Todo:
|
d198d0e
to
eb274c0
Compare
eb274c0
to
2fffd28
Compare
2fffd28
to
a78273f
Compare
* Graduate `ShootForceDeletion` to GA * Correct gardener version * Fix test
There is only one remaining repository (considering default branches only) in github.com/gardener organisation that features a file `_images.tpl`: https://github.com/gardener/gardener-extension-provider-aws However, said repository no longer seems to vendor gardener/gardener's copy of component_descriptor script. Rm unused codepath as cleanup (will help migrating from Concourse-Pipeline-Template).
…untime (gardener#11113) * Use role 'garden-cert' for wildcard TLS certificate used for Garden runtime * address review feedback
…dPredicate` and `dnsrecord` controller. (gardener#11123) * Ignore non-shoot namespaces in shootNotFailedPredicate and dnsrecord controller * Avoid calling GetCluster for dnsrecord and extension controllers if not garden namespace * fix test description Co-authored-by: Marc Vornetran <[email protected]> * refactoring to address review feedback * address review feedback: use shared IsShootNamespace method --------- Co-authored-by: Marc Vornetran <[email protected]>
In the "seed is garden" case, the `VPAEvictionRequirements` controller is responsible for shoot namespaces as well. Hence, it needs permissions to update/patch VPA resources in those namespaces.
Co-authored-by: Gerrit <[email protected]> Co-authored-by: Claus-Theodor Riegg <[email protected]> Co-authored-by: Luca Bernstein <[email protected]>
e2b4166
to
264d8f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a draft.