Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some firewall machine status fields are optional. #52

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Some firewall machine status fields are optional. #52

merged 2 commits into from
Apr 2, 2024

Conversation

Gerrit91
Copy link
Contributor

@Gerrit91 Gerrit91 commented Mar 25, 2024 •
edited
Loading

References metal-stack/metal-api#515.

If the metal-api sends nil for some slices, the following error will be thrown, which will make the controllers stuck:

err":"Firewall.firewall.metal-stack.io \"shoot--pbs4kr-foo-firewall-e8577\" is invalid: status.firewallNetworks.destinationPrefixes: Required value"

@Gerrit91 Gerrit91 mentioned this pull request Mar 25, 2024
Merged
@Gerrit91 Gerrit91 marked this pull request as ready for review March 26, 2024 10:23
@Gerrit91 Gerrit91 requested a review from a team as a code owner March 26, 2024 10:23
@Gerrit91 Gerrit91 changed the title Some firewall machine status fields became optional. Some firewall machine status fields are optional. Mar 26, 2024
@Gerrit91 Gerrit91 requested a review from majst01 April 2, 2024 09:10
@majst01 majst01 merged commit 55f40f6 into main Apr 2, 2024
2 checks passed
@majst01 majst01 deleted the optional-fields branch April 2, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majst01 majst01 majst01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gerrit91 @majst01