Refactor test_generation.py: Parameterize text model tests and add edge case #224
Conversation
borgesenioc
commented
Nov 20, 2024
borgesenioc
commented
- Used @pytest.mark.parametrize to simplify and reuse dialog tests in TestTextModelInference.
- Added a new test case for handling empty dialog inputs to improve edge case coverage.
- Maintained the vision model tests in skipped state with @unittest.skip and @pytest.mark.skip.
- Improved overall readability and modularity of the test file.
Refactor test_generation.py: Parameterize text model tests and add edge case - Used @pytest.mark.parametrize to simplify and reuse dialog tests in TestTextModelInference. - Added a new test case for handling empty dialog inputs to improve edge case coverage. - Maintained the vision model tests in skipped state with @unittest.skip and @pytest.mark.skip. - Improved overall readability and modularity of the test file.
Update test_generation.py
borgesenioc
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn and
raghotham
as code owners
|
Hi @borgesenioc! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
| def test_run_generation(self): | ||
| dialogs = [ | ||
| @pytest.mark.parametrize( | ||
| "dialogs", |
There was a problem hiding this comment.
shouldn't the parameter be dialog and the test doesn't loop at all?
