Merge pull request #24 from klpx/log-level-parameter

Proper log level setup
messagebird · Feb 8, 2019 · bc996ba · bc996ba
2 parents 9fef68d + 86629d9
commit bc996ba
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,4 @@
+/.idea/
 *.deb
 *.swp
 /bin

diff --git a/README.md b/README.md
@@ -38,10 +38,10 @@ Use the `-h` flag to get help information.
 ```
 $ pushprom -h
 Usage of bin/pushprom:
-  -debug
-        Log debugging messages.
   -http-listen-address string
         The address to listen on for http stat and telemetry requests. (default ":9091")
+  -log-level string
+        Log level: debug, info (default), warn, error, fatal. (default "info")
   -udp-listen-address string
         The address to listen on for udp stats requests. (default ":9090")
 ```

diff --git a/main.go b/main.go
@@ -13,7 +13,7 @@ import (
 )
 
 var (
-	debug             = flag.Bool("debug", false, "Log debugging messages.")
+	logLevel          = flag.String("log-level", "info", "Log level: debug, info (default), warn, error, fatal.")
 	udpListenAddress  = flag.String("udp-listen-address", "0.0.0.0:9090", "The address to listen on for udp stats requests.")
 	httpListenAddress = flag.String("http-listen-address", "0.0.0.0:9091", "The address to listen on for http stat and telemetry requests.")
 )
@@ -26,6 +26,10 @@ func main() {
 
 	var err error
 
+	if err = logger.SetLevel(*logLevel); err != nil {
+		log.Fatalf(err.Error())
+	}
+
 	*udpListenAddress, err = ListenAddress(*udpListenAddress)
 	if err != nil {
 		log.Fatalf(err.Error())

diff --git a/udp.go b/udp.go
@@ -37,9 +37,9 @@ func listenUDP(ctx context.Context, log plog.Logger) {
 			continue
 		}
 		udpPacketCount.Inc()
-		if *debug {
-			log.Debugf("new udp package: %s", string(buf[0:n]))
-		}
+
+		log.Debugf("new udp package: %s", string(buf[0:n]))
+
 		delta, err := NewDelta(bytes.NewBuffer(buf[0:n]))
 		if err != nil {
 			log.Error("Error creating delta: ", err)
-Original file line number
+Diff line change
@@ -1,3 +1,4 @@
+    /.idea/
     *.deb
     *.swp
     /bin
@@ Expand Down @@