Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crashing of catalog items on page load #1975

Merged
merged 4 commits into from
Nov 30, 2024

Conversation

vishalvivekm
Copy link
Contributor

@vishalvivekm vishalvivekm commented Nov 30, 2024

Description

This PR fixes #1852

Notes for Reviewers

  • removes repetitive for-loops in catalog/index.html
  • removes display of all cards at page load ( cause or reported crashes)
  • only show at max 9 cards when navigating through the catalog, or when no technology or category is selected.
  • adds background color to pattern chips to make the pattern-type visible

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit c07368f
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/674ae1f6eb085c00084197af
😎 Deploy Preview https://deploy-preview-1975--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vishalvivekm vishalvivekm merged commit 3d0ec58 into meshery:master Nov 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All items displayed on page load
1 participant