Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add a command to execute visual test #6222

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

sidharthv96
Copy link
Member

📑 Summary

We run out of Argos limit regularly, which breaks every PR.
A new command is being tested, which will trigger visual test when necessary.

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Jan 25, 2025

⚠️ No Changeset found

Latest commit: edc1ae1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jan 25, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit edc1ae1
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/67947c6a4fb08e000895a6cd
😎 Deploy Preview https://deploy-preview-6222--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Jan 25, 2025

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6222
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6222
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6222
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6222

commit: edc1ae1

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.47%. Comparing base (74a56fc) to head (edc1ae1).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6222   +/-   ##
=======================================
  Coverage     4.47%   4.47%           
=======================================
  Files          385     385           
  Lines        54190   54190           
  Branches       598     598           
=======================================
  Hits          2425    2425           
  Misses       51765   51765           
Flag Coverage Δ
unit 4.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sidharthv96
Copy link
Member Author

/visual-test

@sidharthv96 sidharthv96 merged commit ba53498 into develop Jan 25, 2025
23 of 24 checks passed
@sidharthv96 sidharthv96 deleted the sidv/visualTestComment branch January 25, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant