Fix-warnings #1181
Merged
Fix-warnings #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added missing `None` argument in `bench_search` function. - Simplified match statements to if conditions in `handle_index_command`. - Removed unnecessary `unwrap_or_else` and replaced with `unwrap_or` in `read_to_string`. - Updated argument passing style for `Command::args` to use array syntax. - Improved formatting and removed redundant lines in various functions. - Added `#[allow(clippy::too_many_arguments)]` to several functions to suppress warnings. - Enhanced test cases by removing unnecessary lines and improving readability. - General code cleanup for better maintainability.
…n and clean up core.rs
…es to use `Path` instead of `PathBuf`, and enhance VAD sensitivity enum with a default variant
…ean up monitor and screenshot capture functions
…s multiple files; update assertions and argument passing style in tests
…nstructured OCR; improve code readability and reduce unnecessary lines
…pe-app version to 0.26.6, clean up argument passing style, and enhance permission handling
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
where do you get warnings? dont get any also which errors? changes seem to make sense |
Warnings from Errors from test files that haven't been updated. |
|
testing now |
|
wonder if there is a way to force all contributor to same rust style, eg when you save a file that it automatically format in the same way, same indentation etc. |
|
There should be a config file for a linter that we can use
…On Mon, Jan 27, 2025 at 10:20 AM Louis Beaumont ***@***.***> wrote:
wonder if there is a way to force all contributor to same rust style, eg
when you save a file that it automatically format in the same way, same
indentation etc.
—
Reply to this email directly, view it on GitHub
<#1181 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AL7TPLKU2TS2PPUONBW7RDD2MZMFNAVCNFSM6AAAAABVT2DQG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJWGIZTKNZUGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
/tip $80 @EzraEllette thx |
|
🎉🎈 @EzraEllette has been awarded $80! 🎈🎊 |
|
I think a better route would be to add pre-commit hooks for linting and formatting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes warnings and errors in screenpipe.
One "major" change is the addition of a
rust-toolchain.tomlfile that sets the rust version to1.84.0for the entire repo.