-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin store new #1169
base: main
Are you sure you want to change the base?
Plugin store new #1169
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
few questions that pops up:
related: https://github.com/louis030195/screen-pipe-website/pull/23 @m13v feel free to add any feedback |
also does the cli login flow works without the tauri app running? |
I'm not sure how that can happen as it's entirely different package only intended for developers and exists only on the plugin documentation page.
From my experience it's counter intuitive as the CLI does not have anything in common nor interacts with the core backend. From a contributor's perspective If I cloned the developer backend repo I would also expect to find the CLI there instead of the end user repo. Also from a maintainability perspective it's much simpler since the API routes live in the same repo as opposed to being fragmented in a huge unrelated repo.
Agreed on this, will look into it.
Yes, we're storing the Next.js
Purchase proceeds are immediately transferred to the developer's connected Stripe account after deducting your platform fees (It's configurable in the backend PR). Also the transfer process is handled and automated by Stripe.
You can start testing it now, the core features work. |
the CLI is only intended for developers, nontechnical users don't use terminal at all also it will conflict in the PATH, basically they will lose the backend CLI as it's the same name |
So package name is this
As for the executable itself we could add
Let me know what you think. |
i'm good with it let's find a way to add a validation / feedback step from us want to merge this ASAP, ideally today so we can announce in our newsletter etc. ideas:
concerns:
also we're going to hide the concept of credit in the UI in the future (or make it named as "balance") but still use it in the backend (unrelated to this PR i believe) |
a.mp4
/closes #1112
/claim #1112