Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): duplicate sessions shown in sessions overview #1668

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

detj
Copy link
Contributor

@detj detj commented Dec 25, 2024

Summary

This PR addresses an issue where duplicate sessions would be queried with inaccurate session duration computations. Query performance overhead for large sessions is negligible.

Tasks

  • Avoid duplicate session entry when computing sessions list for sessions overview
  • Verify session duration computation is accurate

See also

- avoid duplicate session entry when computing sessions list for
sessions overview
- verify session duration computation is accurate

fixes #1556

Signed-off-by: detj <[email protected]>
@detj detj added bug something isn't working backend backend related labels Dec 25, 2024
@detj detj self-assigned this Dec 25, 2024
Copy link

vercel bot commented Dec 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
measure-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 25, 2024 9:02pm

@detj detj requested a review from abhaysood December 25, 2024 21:02
@detj detj merged commit 227992b into main Dec 26, 2024
10 checks passed
@detj detj deleted the duplicate-sessions branch December 26, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend backend related bug something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Session IDs are repeated with different durations in sessions table
2 participants