Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-224 | Settings - Username change screen refactor #228

Merged
merged 8 commits into from
Jun 24, 2022

Conversation

mdziekon
Copy link
Owner

@mdziekon mdziekon commented Jun 24, 2022

Summary:

Cleanup of Username change screen code in settings.php file.

Changelog:

  • Move Username change screen code to a separate Screen component & utils
  • Do not hardcode vacation min duration
  • Fix initial display of the vacation min time (show 24-hour style of time)
  • Fix current dark energy color display (coloring should be based on username change cost)

Related issues or PRs:

#224

@mdziekon mdziekon added pr:bugfix All pull requests related to fixing bugs pr:refactor All pull requests containing code refactors labels Jun 24, 2022
@mdziekon mdziekon merged commit 44ec67b into master Jun 24, 2022
@mdziekon mdziekon deleted the gh-224-simplify-nickchange-screen branch June 24, 2022 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:bugfix All pull requests related to fixing bugs pr:refactor All pull requests containing code refactors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant