Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @container at-rule #853

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+44 −0
Open

feat: add @container at-rule #853

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e924dd1
feat: add container at rule
Netail Dec 24, 2024
067b698
fix: feedback
Netail Dec 25, 2024
2e8f177
Merge branch 'main' into feat/container-at-rule
bsmth Jan 15, 2025
ba5fd47
Merge branch 'main' into feat/container-at-rule
Netail Jan 15, 2025
8754943
Merge branch 'main' into feat/container-at-rule
Netail Jan 20, 2025
1b3c5d7
add syntaxes
Netail Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions css/at-rules.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,20 @@
"status": "standard",
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/@counter-style"
},
"@container": {
"syntax": "@container <container-condition># {\n <block-contents>\n}",
Copy link
Contributor

@skyclouds2001 skyclouds2001 Dec 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"syntax": "@container <container-condition># {\n <block-contents>\n}",
"syntax": "@container <container-condition># {\n <block-contents>\n}",

the syntax need to add to syntaxes.json if it is not existed in that file

e.g. #835

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still outstanding, right? I don't get any matches on this branch for @container aside from ./css/at-rules.json:

grep -r "@container" ./
./css/at-rules.json:  "@container": {
./css/at-rules.json:    "syntax": "@container <container-condition># {\n  <group-rule-body>\n}",
./css/at-rules.json:    "mdn_url": "https://developer.mozilla.org/docs/Web/CSS/@container"

Copy link
Author

@Netail Netail Jan 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, but unsure about the following 3; https://github.com/mdn/data/pull/853/files#diff-bf23b9edf4e332a630c103de7fc52e4eecc7d5262a21ac5feb2cc04a76cf2f40R230-R238, couldn't find any documentation

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skyclouds2001, do you happen to know the answer to these 3?

"interfaces": [
"CSSGroupingRule",
"CSSConditionRule",
"CSSContainerRule"
],
Netail marked this conversation as resolved.
Show resolved Hide resolved
"groups": [
"CSS Conditional Rules",
"CSS Containment"
],
Netail marked this conversation as resolved.
Show resolved Hide resolved
"status": "standard",
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/@container"
},
"@document": {
"syntax": "@document [ <url> | url-prefix(<string>) | domain(<string>) | media-document(<string>) | regexp(<string>) ]# {\n <group-rule-body>\n}",
"interfaces": [
Expand Down