Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor generate source #311

Closed

Conversation

User4martin
Copy link

See comments on #295

@User4martin User4martin mentioned this pull request Oct 23, 2017
@User4martin
Copy link
Author

See also #288

  • Move old style include into scanline

  • Move checking for missing close tag into scanline

  • In Scanline break the case into groups.
    first group all cases that start with <
    2nd group all cases that end in >
    putting each group into an if gives some extra speed.
    (isHandled is needed for the 3rd group, not matched by any before)


The isHandled will be removed in one of the later pull requests. As the entire switch structure will be changed.

@User4martin User4martin force-pushed the refactor-generate-source branch from d3b6358 to 7250566 Compare October 23, 2017 21:43
@RyanZim
Copy link
Collaborator

RyanZim commented Oct 23, 2017

Thanks for doing this; will try to review this when I get a chance; please ping me if anything is waiting my attention for more than 7 days.

@RyanZim
Copy link
Collaborator

RyanZim commented Jul 11, 2018

As is probably obvious, I haven't gotten around to reviewing this for a long while, and with my work schedule, it's unlikely I can make this a priority anytime soon. I'll leave this for the other maintainers.

@RyanZim RyanZim removed their request for review July 11, 2018 18:13
@mde mde deleted the branch mde:master May 30, 2022 16:34
@mde mde closed this May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants