added custom output function name

[oscarotero]

According with #244 I've added a new option to define an output function name like echo or print. Example:

<h1><% echo('hello world') %></h1>

var ret = ejs.compile(string, {
    filename: path,
    outputFunctionName: 'echo'
})(data);

Any suggestion is welcome

[mde]

Since echo is a function, there shouldn't be a space between the function name and the parens. Should look like echo(user.species);.

Also, rather than having this example mixed together with the output tag, might it not make sense to have a totally separate example?

[mde]

Same feedback as above -- since this is not likely the default use-case, it make make more sense to make this a separate example.

[mde]

I've added a couple of comments. Sorry for the delay in responding.

[oscarotero]

Thank for the feedback. I've commited the changes.

[mde]

Looks like you neglected to change all tags to script-execution tags. In fact, you might want to make your example look more like your real use-case. For example, you might want to use output during debugging or something? You could even include a couple of examples of different ways to use it. It's good for people to know why this feature exists.

[mde]

One more comment .... :)

[mde]

Also, did you verify if it plays nicely with the line-numbers in errors?

[oscarotero]

Ok, now it has a more realistic example.
and about the line-numbers in errors, this is an example:

    1| <ul>
 >> 2| <%
    3|     users.forEach(function (user) {
    4|         echo(a + '<li>');
    5|             echo('<strong>' + user.name + '</strong>');

a is not defined

as you can see, the error is in line 4, not 2, not sure whether it's a problem with echo.

[mde]

Try your same error without the echo call, and see if the line number in the error is correct.

[oscarotero]

Same error:

    1| <ul>
 >> 2| <%
    3|     users.forEach(function (user) {
    4|         a = b;
    5|             echo('<strong>' + user.name + '</strong>');

b is not defined

[mde]

Ah, might be the line number for the opening tag. It's been a long time since I touched that code. I'll play around with it and see what it's doing to make sure this doesn't confuse things.

[oscarotero]

Hi.
I've added an example combining echo and include: 9252132

Any plans for a new release including this feature?

[RyanZim]

Code LGTM, needs docs yet.

@mde @User4martin Thoughts on this?

[User4martin]

Should also include a test case.

@mde @RyanZim
IMHO it would be better (more consistent with existing code) if "echo" would be passed as param to the function.

In case of opts.client it can have be tested for undefined, and set to __append in that case.

[sziberov]

Any changes on this? Really want this feature, as I several days ago switched to Node from PHP and having similar syntax would be amazing for me.

[ViktorQvarfordt]

Is this not sufficient?

<% for (const user of users) { %>
  <li><%= user.name %></li>
<% } %>

[mde]

Sorry for the lengthy delay on this. I've verified there's no change to line numbers in errors. Thanks very much for this!

[oscarotero]

Great!

[iagobruno]

@ViktorQvarfordt is more readable.