fix(StationInformation): show bike/parking info even for non-stations #2346
Conversation
thecristen
force-pushed
the
cbj/stop-page-facility-info
branch
from
b7546e4 to
6572c5d
Compare
| @@ -128,10 +128,6 @@ | |||
| margin-top: -.313rem; | |||
| } | |||
|
|
|||
| .u-mt-6 { | |||
| @@ -23,7 +23,7 @@ const accessibilityNames: { | |||
|
|
|||
| const StationFeatures = (features: AccessibilityType[]): JSX.Element => ( | |||
| <> | |||
| <h2 className="text-2xl">Station Features</h2> | |||
There was a problem hiding this comment.
Curiosity: Did you remove this because it wasn't necessary (and is kind of antipattern-y)? Or because it was wrong?
There was a problem hiding this comment.
Okay - this does change the font size (makes it a bit smaller). Is that intentional as part of this work?
There was a problem hiding this comment.
This PR is actually two changes - one that does what the PR title says, and another unifies the h2 tag styles and changes the appearance of the amenity cards. I'm a bit worried about merging in visual changes after Chase brought up stylistic instability in the most recent retro.
I'm 👍 on the don't-suppress-parking-and-bikes part, so if you wanted to scope this PR down to just that, and push the h2 fixes to a different one, I would happily approve.
Before
After
If there is buy-in from design on the visual changes, then I'm good to merge this, although I do think this could have been split into two PR's.
Summary of changes
Asana Ticket: Stop pages missing facility information
Before, parking info and bike facility info would be suppressed on stop pages representing bus stops or other "not station" stops. Adjusted the logic so this is no longer the case.
Now we can see...