Increase coverage and consistency of trip planner tests #2336
Conversation
| @@ -265,7 +265,7 @@ defmodule DotcomWeb.Router do | |||
|
|
|||
| scope "/preview", DotcomWeb do | |||
| import Phoenix.LiveView.Router | |||
| pipe_through([:browser, :browser_live, :basic_auth_readonly]) | |||
| pipe_through([:browser, :browser_live]) | |||
There was a problem hiding this comment.
📓 Just did this for convenience since basic auth won't be there in the near future. Will remove this from the PR before merge.
There was a problem hiding this comment.
Why not remove it now?
There was a problem hiding this comment.
I'm going to in a single PR with all of these dangling trip planner tasks.
| Enum.map(1..3, fn _ -> | ||
| Factory.build(:place, stop: Factory.build(:stop)) | ||
| end) |
There was a problem hiding this comment.
Would Factory.build_list(3, :place, stop: Factory.build(:stop)) work just as well?
There was a problem hiding this comment.
Can happen later, I feel like this should be part of OpenTripPlannerClient's factory
There was a problem hiding this comment.
I don't think so because 'grouping' is a dotcom concept not an OTP client concept.
| @@ -265,7 +265,7 @@ defmodule DotcomWeb.Router do | |||
|
|
|||
| scope "/preview", DotcomWeb do | |||
| import Phoenix.LiveView.Router | |||
| pipe_through([:browser, :browser_live, :basic_auth_readonly]) | |||
| pipe_through([:browser, :browser_live]) | |||
There was a problem hiding this comment.
Why not remove it now?
No ticket. I went through the Trip Planner and wrote tests for everything I think we should cover. Tests are focused on behavior and allow appearance testing to be done in the components.