Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OpenTripPlanner): add stop ID to response #1792

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

thecristen
Copy link
Collaborator

Noticed the itineraries were no longer linking to intermediate stops, and that that was from the %NamedPosition{} always having a nil stop_id.

Left is #1791 , right is on current dev - note hyperlinked stop names, attached alert icons.

image

This PR repopulates that value and fixes the result to show links and alert icons as before.

@thecristen thecristen requested a review from a team as a code owner November 7, 2023 22:38
@thecristen thecristen requested review from kotva006 and removed request for a team November 7, 2023 22:38
@kotva006 kotva006 merged commit 0819fef into rk/otp-graphql Nov 9, 2023
@kotva006 kotva006 deleted the cbj/otp-graphql-with-stopid branch November 9, 2023 21:06
kotva006 added a commit that referenced this pull request Nov 14, 2023
* feat(deps): Added absinthe_client and updated mint dependency

* feat(OTP): Updated the API to use the graphql endpoint of OTP

* Fixed tests

* More cleanup

* Increased walk reluctance and fixed unit tests

* feat(OpenTripPlanner): add stop ID to response (#1792)

* Fixed unite tests

* Fixed error messages, and error tests

---------

Co-authored-by: Cristen Jones <cjones3@mbta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants