feat(Alerts): display updated_at timezone (#1890)

* feat(Alerts): display updated_at timezone * fixup: use Boston time
mbta · Feb 15, 2024 · fa86484 · fa86484
1 parent 6b8026a
commit fa86484
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/assets/ts/components/Alerts.tsx b/assets/ts/components/Alerts.tsx
@@ -1,5 +1,4 @@
 import React, { ReactElement, useState } from "react";
-import { format, parseISO } from "date-fns";
 import { Alert as AlertType, Lifecycle } from "../__v3api";
 import { handleReactEnterKeyPress } from "../helpers/keyboard-events-react";
 import { caret } from "../helpers/icon";
@@ -8,6 +7,7 @@ import shuttleIcon from "../../static/images/icon-shuttle-default.svg";
 import cancelIcon from "../../static/images/icon-cancelled-default.svg";
 import snowIcon from "../../static/images/icon-snow-default.svg";
 import alertIcon from "../../static/images/icon-alerts-triangle.svg";
+import { formatToBostonTime } from "../helpers/date";
 
 interface Props {
   alerts: AlertType[];
@@ -206,7 +206,8 @@ const alertDescription = (alert: AlertType): ReactElement<HTMLElement> => (
       />
       {alert.updated_at && (
         <div className="c-alert-item__updated">
-          Updated: {format(parseISO(alert.updated_at), "M/d/yyyy h:mm aa")}
+          Updated:{" "}
+          {formatToBostonTime(alert.updated_at, "M/d/yyyy h:mm aa zzz")}
         </div>
       )}
     </div>

diff --git a/assets/ts/components/__tests__/__snapshots__/AlertsTest.tsx.snap b/assets/ts/components/__tests__/__snapshots__/AlertsTest.tsx.snap
@@ -86,8 +86,9 @@ exports[`it renders 1`] = `
                 <div
                   className="c-alert-item__updated"
                 >
-                  Updated: 
-                  4/11/2019 9:33 AM
+                  Updated:
+                   
+                  4/11/2019 10:33 AM EDT
                 </div>
               </div>
             </div>

diff --git a/lib/alerts/parser.ex b/lib/alerts/parser.ex
@@ -73,6 +73,10 @@ defmodule Alerts.Parser do
     defp parse_time(str) do
       str
       |> Timex.parse!("{ISO:Extended}")
+      # While the time strings are already notated with -05 Etc/GMT+5 or -04
+      # Etc/GMT+4 time zone, this additional conversion gives the DateTime a
+      # nicer timezone abbreviation (EST or EDT)
+      |> Timex.Timezone.convert("America/New_York")
     end
 
     # remove leading/trailing whitespace from description

diff --git a/lib/dotcom_web/views/alert_view.ex b/lib/dotcom_web/views/alert_view.ex
@@ -177,7 +177,7 @@ defmodule DotcomWeb.AlertView do
         Timex.format!(updated_at, "{M}/{D}/{YYYY}")
       end
 
-    time = format_schedule_time(updated_at)
+    time = Timex.format!(updated_at, "{h12}:{m} {AM} {Zabbr}")
 
     ["Updated: ", date, 32, time]
   end