-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/simpleping 2016 #22
Open
jpalten
wants to merge
5
commits into
mavris:master
Choose a base branch
from
jpalten:update/simpleping-2016
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs more testing, in combination with other processes there might be an issue. Investigating now. |
…nal SimplePing class
Did more testing, seems to work fine for me. |
Hey dude. I will make some tests next week and I will merge your pull. Thanks for your effort |
…impleping-2016 # Conflicts: # MMLanScan/Misc/PingOperation.m # MMLanScanDemo/MMLanScanDemo.xcodeproj/project.pbxproj
Any updates here? MMLanScan is periodically crashing on me in SimplePing. |
MMLanScan is periodically crashing in SimplePing. |
elisgjana
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update SimplePing to latest version from Apple.
Also fix type booboo in MainPresenter of Demo.