refactor: Remove the pkcs7 crate from the list of dependencies #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pkcs7 crate has been deprecated[1], the authors recommend us to switch to the block_padding crate instead. Incidentally we're already using the block_padding crate for our pkcs7 needs as that one is re-exported by the AES crate. This means that the pkcs7 crate is already an unused dependency and we can just remove it. This has been confirmed by cargo-udeps[2] as well. [1]: https://docs.rs/pkcs7/0.4.1/pkcs7/index.html#-deprecated- [2]: https://github.com/est31/cargo-udeps
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
=======================================
Coverage ? 90.55%
=======================================
Files ? 34
Lines ? 1905
Branches ? 0
=======================================
Hits ? 1725
Misses ? 180
Partials ? 0 ☔ View full report in Codecov by Sentry. |
dkasak
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pkcs7 crate has been deprecated1, the authors recommend us to switch to the block_padding crate instead.
Incidentally we're already using the block_padding crate for our pkcs7 needs as that one is re-exported by the AES crate. This means that the pkcs7 crate is already an unused dependency and we can just remove it.
This has been confirmed by cargo-udeps2 as well.
This closes: #162.
Footnotes
https://docs.rs/pkcs7/0.4.1/pkcs7/index.html#-deprecated- ↩
https://github.com/est31/cargo-udeps ↩