-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track the number of ratchet advances in the Olm Session, and include it in the debug output. #134
Conversation
8662b17
to
5d9e3a8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
==========================================
- Coverage 84.72% 84.65% -0.08%
==========================================
Files 32 32
Lines 1768 1786 +18
==========================================
+ Hits 1498 1512 +14
- Misses 270 274 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I left some nits and I'm going to require tests for this one.
CHANGELOG.md
Outdated
@@ -2,6 +2,12 @@ | |||
|
|||
All notable changes to this project will be documented in this file. | |||
|
|||
## UNRELEASED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid I need to inform you that vodozemac never abandoned git-cliff
for changelog entries. So this belongs in a commit message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, right. Presumably putting it in the subject line of the PR, and then squash-merging the PR, will do the right sort of thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as it's a conventional commit it will be picked up, since you historically complained that commit messages don't make great changelog entries you can put the conventional commit into a merge commit.
The merge commit message is anyways useless so it's a good opportunity to repurpose it for a better cause.
In the future I'd like to make it possible so you can have a special tag in merge commits which will mark the start of the changelog entry, similar to how the Signoff
is treated specially in commit messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, well, I've removed this for now.
@poljar: have added some tests. Let me know what you think. Happy to add more if you have suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the tests.
5599cef
to
ab00f4b
Compare
In order to help understand Olm decryption errors, let's keep track of the number of DH ratchet clicks, and log them as part of the debug output.