-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC3266: Room summary API #3266
base: old_master
Are you sure you want to change the base?
Conversation
Signed-off-by: Nicolas Werner <[email protected]>
855306e
to
642f4e1
Compare
Signed-off-by: Nicolas Werner <[email protected]>
Signed-off-by: Nicolas Werner <[email protected]>
…est of the path separate Signed-off-by: Nicolas Werner <[email protected]>
That way the requesting server knows, if any user would have access to that room and it can forward the room to the user. Signed-off-by: Nicolas Werner <[email protected]>
As well as a few smaller clarifications.
Okay, I updated the MSC with most of the experiences I had with it from the last 2 years. Also shields.io now uses it, so does that remove your concerns regarding the unauthenticated usage, @turt2live? It apparently is a lot better than their previous approach of registering a new guest user per request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't perfectly verified the implementation matches, especially on the server side, but this has been sitting for far too long anyways. Let's ship it.
@mscbot fcp merge |
Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people: Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for information about what commands tagged team members can give me. |
Co-authored-by: Richard van der Hoff <[email protected]> Co-authored-by: Patrick Cloke <[email protected]>
It suffers from the same knock_restricted issue.
I've given this a green tick in order not to block its progress, given the MSC as a whole is definitely useful and very proven at this point. @deepbluev7 can you please deal with the remaining open PR comments though (e.g. spelling out what 'public' means; etc)? |
Mautrix has also implemented it now: https://github.com/mautrix/go/releases/tag/v0.23.0 |
This has got stuck waiting for updates once more, so in the interests of pushing it over the line, the Spec Core Team are going to make the final few updates. |
Co-authored-by: Eric Eastwood <[email protected]> Co-authored-by: Patrick Cloke <[email protected]>
Rendered.
Somewhat related to MSC2946 this provides an API to get a summary for a specific room either from the local server or over federation.
Useful for a few cases, where you need to show a summary for a room like matrix.to, traveler bots, showing spaces, lightweight clients, etc.
Open design questions looking for feedback: see this comment chain: #3266 (comment)resolved as of 2021/10/06Implementations:
allowed_room_ids
part is implemented here: deepbluev7/synapse@37f4253.Signed-off-by: Nicolas Werner [email protected]
SCT stuff:
Shepherd: @richvdh
FCP tickyboxes
Checklist: #3266 (comment)