feat(sdk): event_cache::Deduplicator is able to learn without scanning
#4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nning. This patch adds the `Deduplicator::learn` method to learn only without scanning new events. This is useful to rebuild a `Deduplicator` iteratively.
Hywan
requested review from
jmartinesp and
bnjbvr
and removed request for
a team and
jmartinesp
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4652 +/- ##
==========================================
+ Coverage 85.68% 85.69% +0.01%
==========================================
Files 292 292
Lines 33570 33570
==========================================
+ Hits 28763 28767 +4
+ Misses 4807 4803 -4 ☔ View full report in Codecov by Sentry. |
bnjbvr
requested changes
Feb 11, 2025
Comment on lines
213
to
216
| // `RoomEvents` is used to check false-positive from the bloom filter. `event_0` | ||
| // and `event_2` are going to be detected as positive (duplicated), so | ||
| // `RoomEvents` will be used. We need to insert `event_0` and `event_2` in it | ||
| // too. |
There was a problem hiding this comment.
I don't understand this comment at all, sorry. Can you reformulate it?
There was a problem hiding this comment.
Sure! It's a bit confusing indeed. I've reformulate entirely.
|
Turns out we don't need this, thanks to #4662 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the
Deduplicator::learnmethod to learn only without scanning new events. This is useful to rebuild aDeduplicatoriteratively.EventCachestorage #3280EventCachelazy-loading #4632