Minor improvement of spec.AsTimestamp #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's safer to convert time.Time using a standard "t.UnixMilli()" method instead of "t.UnixNano() / 1000000"
mdnight
changed the title
2 tasks
mdnight
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
==========================================
+ Coverage 59.40% 59.43% +0.02%
==========================================
Files 51 51
Lines 7257 7257
==========================================
+ Hits 4311 4313 +2
+ Misses 2546 2544 -2
Partials 400 400 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a bit safer to convert
time.Timeusing a standardt.UnixMilli()method rather thant.UnixNano() / 1000000Pull Request Checklist
Signed-off-by:
Roman Isaev <[email protected]>