Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export function to detect if wallet plugin is installed #201

Merged
merged 5 commits into from
Feb 7, 2024
Merged

Export function to detect if wallet plugin is installed #201

merged 5 commits into from
Feb 7, 2024

Conversation

Ben-Rey
Copy link
Contributor

@Ben-Rey Ben-Rey commented Feb 5, 2024

No description provided.

@Ben-Rey Ben-Rey force-pushed the detect-if-wallet-plugin-installed branch from ca0eb98 to 5228c16 Compare February 5, 2024 14:31
@Ben-Rey Ben-Rey force-pushed the detect-if-wallet-plugin-installed branch from 5228c16 to 8625fe0 Compare February 5, 2024 14:35
@Ben-Rey Ben-Rey force-pushed the detect-if-wallet-plugin-installed branch from 7044569 to 20b3f4e Compare February 5, 2024 21:08
@Ben-Rey Ben-Rey force-pushed the detect-if-wallet-plugin-installed branch from 20b3f4e to 13bda65 Compare February 5, 2024 21:16
@Ben-Rey Ben-Rey requested review from Thykof and peterjah February 5, 2024 21:18
@Ben-Rey Ben-Rey requested a review from Thykof February 6, 2024 10:22
Thykof
Thykof reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@Thykof Thykof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the most important I thing is to knwon if the wallet plugin is enable, and we also want to know if at least massa station is running

src/providersManager/providerList.ts Outdated Show resolved Hide resolved
src/massaStation/MassaStationDiscovery.ts Outdated Show resolved Hide resolved
src/massaStation/MassaStationDiscovery.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Ben-Rey Ben-Rey merged commit ccae603 into main Feb 7, 2024
6 checks passed
@Ben-Rey Ben-Rey deleted the detect-if-wallet-plugin-installed branch February 7, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thykof Thykof Thykof left review comments

@peterjah peterjah peterjah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ben-Rey @Thykof @peterjah