Merge pull request #185 from massalabs/some-improvements

various improvements

package.json

@@ -12,7 +12,7 @@
         "clean-dist": "rimraf dist/*",
         "build-esm": "tsc --project tsconfig.esm.json",
         "build-commonjs": "tsc --project tsconfig.commonjs.json",
-        "build": "npm run fmt && npm-run-all clean-dist build-*",
+        "build": "npm-run-all clean-dist build-*",
         "test-extension:serve-dapp": "cd test-extension/dapp-vite && npm run preview",
         "test-extension": "cd ./test-extension && npx playwright test",
         "unit-test-commonjs": "jest --config ./jest.config.commonjs.js",

src/bearbyWallet/BearbyAccount.ts

@@ -16,7 +16,6 @@ import { NodeStatus } from './NodeStatus';
 import { JSON_RPC_REQUEST_METHOD } from './jsonRpcMethods';
 import axios, { AxiosRequestHeaders, AxiosResponse } from 'axios';
 import { IAccountSignOutput } from '../account/AccountSign';
-import { isArrayOfNumbers } from '../utils/typeCheck';
 /**
  * The maximum allowed gas for a read operation
  */
@@ -193,15 +192,20 @@ export class BearbyAccount implements IAccount {
       );
     }
 
+    let unsafeParameters = Uint8Array.from([]);
+    if (parameter instanceof Args) {
+      unsafeParameters = Uint8Array.from(parameter.serialize());
+    } else {
+      unsafeParameters = parameter;
+    }
+
     const operationId = await web3.contract.call({
       maxGas: Number(maxGas),
       coins: Number(amount),
       fee: Number(fee),
       targetAddress: contractAddress,
       functionName: functionName,
-      unsafeParameters: isArrayOfNumbers(parameter)
-        ? (parameter as Uint8Array)
-        : ((parameter as Args).serialize() as unknown as Uint8Array),
+      unsafeParameters,
     });
 
     return { operationId };

src/massaStation/MassaStationAccount.ts

@@ -315,7 +315,7 @@ export class MassaStationAccount implements IAccount {
       nickname: this._name,
       name: functionName,
       at: contractAddress,
-      args: args,
+      args,
       coins: Number(coins),
       fee: fee ? fee.toString() : '0',
       // If maxGas is not provided, estimation will be done by MS