Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chain ID #856

Merged
merged 13 commits into from
Jan 2, 2024
Merged

Add chain ID #856

merged 13 commits into from
Jan 2, 2024

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Dec 18, 2023 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Dec 18, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec65869) 55.08% compared to head (d81aa50) 55.08%.

❗ Current head d81aa50 differs from pull request most recent head 1e60e08. Consider uploading reports for the commit 1e60e08 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #856   +/-   ##
=======================================
  Coverage   55.08%   55.08%           
=======================================
  Files          41       41           
  Lines        2371     2371           
=======================================
  Hits         1306     1306           
  Misses        890      890           
  Partials      175      175

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thykof Thykof changed the title Add chain Add chain ID Dec 18, 2023
@Thykof Thykof mentioned this pull request Dec 18, 2023
Closed
@Thykof Thykof self-assigned this Dec 18, 2023
@Thykof Thykof marked this pull request as draft December 19, 2023 15:05
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@damip damip marked this pull request as ready for review January 2, 2024 11:23
@damip
Copy link
Member

damip commented Jan 2, 2024

CI seems to fail

@Thykof
Copy link
Contributor Author

Thykof commented Jan 2, 2024

CI seems to fail

it fails because buildnet is not handling chain id yet.

@damip damip merged commit 6be1225 into main Jan 2, 2024
16 of 17 checks passed
@damip damip deleted the add-chain-id branch January 2, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-senechal thomas-senechal thomas-senechal approved these changes

@peterjah peterjah peterjah approved these changes

Assignees

@Thykof Thykof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thykof @damip @peterjah @thomas-senechal