Allow patch constant to patch type like Option<T> and to replace comp… #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
bilboquet
approved these changes
May 14, 2024
bilboquet
requested changes
May 17, 2024
| @@ -26,7 +26,7 @@ def apply(self, root=Path, strip: int = 0, fuzz: bool = False): | |||
| with open(root / self.constant_file, "r+") as fp: | |||
| content = fp.read() | |||
| content_sub = re.sub( | |||
| f"(pub )?const {self.constant_name}: (\w+) = (\w+);", | |||
| f"(pub )?const {self.constant_name}: ([\w\<\>]+) = ([\w\s\*\(\)]+);", | |||
| f"\g<1>const {self.constant_name}: \g<2> = {self.new_value};", | |||
| content, | |||
| ) | |||
There was a problem hiding this comment.
Suggested change
| ) | |
| content_sub = re.sub( | |
| f"(.* const {self.constant_name}[ :].*) = (.*);", | |
| f"\g<1> = {self.new_value};", | |
| content, | |
| ) |
looks more readable to me
we capture the right member of the = sign as long as it contains the correct identifier
then we replace the whole line by <1> = new_value;
Signed-off-by: Jean-François <[email protected]>
bilboquet
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uted values