Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chainID #24

Merged
merged 3 commits into from
Dec 22, 2023
Merged

chainID #24

merged 3 commits into from
Dec 22, 2023

Conversation

modship
Copy link
Member

@modship modship commented Dec 14, 2023

No description provided.

@modship modship mentioned this pull request Dec 14, 2023
Closed
sydhds
sydhds reviewed Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@sydhds sydhds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But let check that other op are ok too (buy, sell rolls, ...)

massa_test_framework/massa_py/operations.py Outdated Show resolved Hide resolved
massa_test_framework/massa_py/operations.py Outdated Show resolved Hide resolved
@modship modship requested a review from sydhds December 15, 2023 09:52
@modship modship requested a review from bilboquet December 15, 2023 14:31
@sydhds sydhds merged commit cb83cb2 into main Dec 22, 2023
1 check failed
@sydhds sydhds deleted the feature/chainid branch December 22, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilboquet bilboquet bilboquet approved these changes

@sydhds sydhds sydhds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@modship @sydhds @bilboquet