Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix address type for call_sc operations #22

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Fix address type for call_sc operations #22

merged 1 commit into from
Dec 8, 2023

Conversation

bilboquet
Copy link
Contributor

No description provided.

@bilboquet bilboquet requested a review from sydhds November 24, 2023 13:58
sydhds
sydhds reviewed Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@sydhds sydhds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (but 1 small comment). Looks like it is just typing and reformating no?

massa_test_framework/node.py Outdated Show resolved Hide resolved
@bilboquet
Copy link
Contributor Author

Looks good to me (but 1 small comment). Looks like it is just typing and reformating no?

Yes mostly. I've used the recommended formatter and made mypy happier.
The only real modification, a bit lost in the format noise, is in CallSC.serialize() i.e., the varint.encode(1) for the address type.

@bilboquet bilboquet force-pushed the fix_call_sc_operations branch from f0f8468 to 4965daa Compare November 28, 2023 11:12
@bilboquet bilboquet merged commit d5c7cc9 into main Dec 8, 2023
1 check failed
@bilboquet bilboquet deleted the fix_call_sc_operations branch December 8, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydhds sydhds sydhds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bilboquet @sydhds