Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC GetStakers #18

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Add gRPC GetStakers #18

merged 3 commits into from
Nov 9, 2023

Conversation

aoudiamoncef
Copy link
Contributor

No description provided.

@aoudiamoncef aoudiamoncef changed the title Add gRPC GetStakers Add gRPC GetStakers + GetStatus Nov 8, 2023
@aoudiamoncef aoudiamoncef changed the title Add gRPC GetStakers + GetStatus Add gRPC GetStakers Nov 8, 2023
@aoudiamoncef aoudiamoncef requested a review from sydhds November 9, 2023 10:57
@aoudiamoncef aoudiamoncef force-pushed the feature/add-grpc-methods branch 2 times, most recently from 5ff807a to f20ae98 Compare November 9, 2023 15:13
def get_stakers_grpc(self) -> GetStakersResponse:
"""gRPC GetStakers.

Example::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to have 2 ":" here?

  • doc example does not match function name

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum in the Example you are calling:

res = node.grpc_get_stakers()

while the function name is:

def get_stakers_grpc(self) -> GetStakersResponse:

Copy link
Contributor Author

@aoudiamoncef aoudiamoncef Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. It was the old naming, sorry

@aoudiamoncef aoudiamoncef requested a review from sydhds November 9, 2023 15:13
@aoudiamoncef aoudiamoncef force-pushed the feature/add-grpc-methods branch from f20ae98 to 2d99f11 Compare November 9, 2023 15:14
@aoudiamoncef aoudiamoncef force-pushed the feature/add-grpc-methods branch from 2d99f11 to ab6fde4 Compare November 9, 2023 15:20
@aoudiamoncef aoudiamoncef merged commit 30d9948 into main Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants