-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use zsh-auto-notify plugin #55
Conversation
- use existing plugin which has several improvements and bugfixes - store as link instead of downloading the plugin since it is seems somewhat abandoned and isn't accepting new fixes to the repo - modify default settings and enable sound
Reviewer's Guide by SourceryThis PR replaces a custom implementation of command completion notifications with the zsh-auto-notify plugin. The plugin is added as a symlink rather than a direct download, and includes customized default settings including sound notifications. The implementation provides more robust notification handling across different platforms (Linux and macOS) and includes additional features like urgency levels and customizable messages. Class diagram for zsh-auto-notify plugin integrationclassDiagram
class AutoNotify {
+int AUTO_NOTIFY_EXPIRE_TIME
+int AUTO_NOTIFY_THRESHOLD
+int AUTO_NOTIFY_TRUNCATE_COMMAND
+string AUTO_NOTIFY_SOUND
+list AUTO_NOTIFY_IGNORE
+void _auto_notify_format(string MESSAGE, string command, int elapsed, int exit_code)
+void _auto_notify_message(string command, int elapsed, int exit_code)
+string _is_auto_notify_ignored(string command)
+void _auto_notify_send()
+void _auto_notify_track(string command, string command_full)
+void _auto_notify_reset_tracking()
+void disable_auto_notify()
+void enable_auto_notify()
}
note for AutoNotify "This class represents the zsh-auto-notify plugin with customizable settings and notification handling."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Merging to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @martimlobao - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider vendoring the plugin code directly instead of linking to it, since the repository is abandoned. This would prevent potential issues if the source repository becomes unavailable.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Integrate the zsh-auto-notify plugin to enhance user experience by providing notifications for long-running terminal commands. Modify default settings to enable sound and adjust notification thresholds for better usability.
New Features:
Enhancements: