Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cleanup and small app updates #42

Merged
merged 2 commits into from
Nov 3, 2024
Merged

Conversation

martimlobao
Copy link
Owner

@martimlobao martimlobao commented Nov 3, 2024

  • uninstall Dropover and PastePal
  • remove deprecated cowsay
  • install syntax-highlight
  • add delete-squashed git alias
  • enable sudo in starship
  • script tweaks

Summary by Sourcery

Clean up and update application configurations and scripts by removing deprecated and unused applications, adding new utilities, and enhancing existing scripts for better functionality.

Enhancements:

  • Improve script for checking and installing yq by moving the check to the beginning of the script.
  • Enhance Mac App Store update process by listing outdated apps before prompting for update.

Chores:

  • Uninstall Dropover and PastePal applications.
  • Remove deprecated cowsay package.
  • Install syntax-highlight application.
  • Add delete-squashed git alias.
  • Enable sudo in starship configuration.

- uninstall Dropover and PastePal
- remove deprecated cowsay
- install syntax-highlight
- add delete-squashed git alias
- enable sudo in starship
- script tweaks
Copy link
Contributor

sourcery-ai bot commented Nov 3, 2024

Reviewer's Guide by Sourcery

This PR implements various system maintenance and cleanup changes across configuration files and scripts. The changes focus on improving app management scripts, updating configuration files, and cleaning up unused applications.

Class diagram for updated app management scripts

classDiagram
    class InstallScript {
        +installed_casks: List
        +installed_formulas: List
        +uv_sync()
        +mas_sync()
        +populate_installed_apps()
    }
    class LocalScript {
        +register_iStatMenus()
    }
    class AppsToml {
        -Dropover
        -PastePal
        +syntax-highlight
    }
    class StarshipConfig {
        +truncation_symbol: String
        +sudo: Boolean
    }
    class GitConfig {
        +delete-squashed: Alias
    }
    note for InstallScript "Ensures yq is installed, updates app management logic"
    note for LocalScript "Reorders iStat Menus registration logic"
    note for AppsToml "Removes Dropover and PastePal, adds syntax-highlight"
    note for StarshipConfig "Adds truncation symbol and enables sudo"
    note for GitConfig "Adds delete-squashed alias"
Loading

File-Level Changes

Change Details Files
Improve app installation and update script functionality
  • Move yq installation check to the beginning of the script
  • Fix formatting in uninstall apps prompt
  • Add conditional check for Mac App Store updates before prompting
  • Show list of outdated Mac App Store apps before update prompt
install.sh
Optimize iStat Menus registration process
  • Reorder operations to fetch credentials before writing defaults
  • Group credential fetching operations together
local.sh
Update application manifest and remove unused apps
  • Remove Dropover and PastePal Mac App Store applications
  • Remove deprecated cowsay formula
  • Add syntax-highlight QuickLook extension
apps.toml
Update Starship shell prompt configuration
  • Add truncation symbol for directory paths
  • Enable sudo module in the prompt
mackup/.config/starship.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martimlobao - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

install.sh Show resolved Hide resolved
@martimlobao martimlobao merged commit b048747 into main Nov 3, 2024
4 of 5 checks passed
@martimlobao martimlobao deleted the chore/cleanup-app-updates branch November 3, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant