Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up prints #108

Merged
merged 1 commit into from
Feb 11, 2025
Merged

chore: Clean up prints #108

merged 1 commit into from
Feb 11, 2025

Conversation

martimlobao
Copy link
Owner

@martimlobao martimlobao commented Feb 11, 2025

  • don't use double spaces for emoji because it's only an issue in Terminal.app/VSCode
  • also rename git alias from 'delete-squashed' to 'cleanup'

Summary by Sourcery

Chores:

  • Remove extra spaces after emojis in print statements.

- don't use double spaces for emoji because it's only an issue in Terminal.app/VSCode
- also rename git alias from 'delete-squashed' to 'cleanup'
Copy link

trunk-io bot commented Feb 11, 2025

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

Copy link
Contributor

sourcery-ai bot commented Feb 11, 2025

Reviewer's Guide by Sourcery

This PR cleans up terminal output formatting by replacing printf with echo -e to address double spacing issues with emoji output across multiple scripts, and it also renames a git alias from 'delete-squashed' to 'cleanup'.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Refactored terminal output formatting for consistency.
  • Replaced printf calls with echo -e for output messages in code.sh.
  • Updated installation and uninstallation messages in install.sh to remove extra double spaces following emojis.
  • Modified oh-my-zsh installation messages in .zshrc to eliminate extra spaces after emojis.
code.sh
install.sh
linkme/.zshrc
Renamed git alias for clarity.
  • Changed the alias from 'delete-squashed' to 'cleanup' in the git configuration.
linkme/.gitconfig

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martimlobao - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider defining a helper function for printing with color codes to avoid repetition.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@martimlobao martimlobao merged commit 38cc0f6 into main Feb 11, 2025
8 checks passed
@martimlobao martimlobao deleted the chore/cleanup-prints branch February 11, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant