Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for update or insert #271

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Add support for update or insert #271

merged 1 commit into from
Aug 26, 2022

Conversation

Jdochoa
Copy link
Contributor

@Jdochoa Jdochoa commented Aug 26, 2022

Add support for update or insert #94

Update Insert

@mariuz mariuz merged commit 5b85264 into mariuz:dev Aug 26, 2022
@arvanus
Copy link
Collaborator

arvanus commented Aug 28, 2022

@Jdochoa could you take a look that it's repeating the insert or update SQL N times, where N=total records - current position
Also if you select more than 1 row, it gets strange

@arvanus
Copy link
Collaborator

arvanus commented Aug 28, 2022

Suggestion, remove the matching part or verify if the selected part has the PK part, if not them omit the patch part. But be aware that you could use another fields to match, or even another unique key (so it's simpler to remove/ignore the matching part)

@Jdochoa
Copy link
Contributor Author

Jdochoa commented Aug 28, 2022

Hi @arvanus
Please review my last commit en dev branch.

./jo

@arvanus
Copy link
Collaborator

arvanus commented Aug 29, 2022

working fine on dev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants