Split marker protocol #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 3, 2017 10:27
sarahsnow1
force-pushed
the
split-marker-protocol
branch
from
47d0759 to
e09b847
Compare
msmollin
approved these changes
Apr 4, 2017
src/Marker.swift
Outdated
| if !userUpdatedSize { return generateBasicStyleString() } | ||
| return "{ style: '\(PointMarker.kPointStyle)', color: '\(backgroundColor.hexValue())', size: [\(size.width)px, \(size.height)px], collide: false, interactive: \(interactive) }" | ||
| } | ||
|
|
src/Marker.swift
Outdated
| func updateStyleString() { | ||
| // override in subclass | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This work splits the
GenericMarkerprotocol into several smaller, more specific protocols. It also creates base implementations for each protocol. In addition, it adds style properties which prevented polygons and lines from showing on the map.Proposed Changes
PointMarker,PolylineMarker,PolygonMarker,SystemPointMarker,SelectableSystemPointMarker, andSystemPolylineMarkerSystemPointMarkersupports current location, route location, and dropped pin pointsSelectableSystemPointMarkersupports search pins, route start pins, and route destination pinsNote:
PolygonMarkers do not support having a "fill color" different from the stroke color. If this effect is wanted, the developer will have to create aPolylineMarkerand overlay it above thePolygonMarkerFuture work will add support for more system markers such as: transit stops, shields, transit lines, and default polygons (#249)