[FEAT] Improvements on Safari Mockup component #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@h3rmel is attempting to deploy a commit to the product-studio Team on Vercel. A member of the Team first needs to authorize it. |
|
@h3rmel so it basically removes extra icons from the top? |
|
@itsarghyadas yes, through a new prop called |
|
And the props basically control the clean mode and the default mode, which includes all the icons. Am I right? |
|
@itsarghyadas exactly |
itsarghyadas
force-pushed
the
h3rmel/safari-mockup-improvement
branch
from
e6c9555 to
a8da79a
Compare
|
@h3rmel Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new prop to Safari that controls it's top bar style:
To use it, just add the
modeprop in the component use and set the value tosimple.