Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fallout from rust-lang/rust#119820 #69

Closed
wants to merge 1 commit into from

Conversation

lcnr
Copy link

@lcnr lcnr commented Mar 5, 2024

See the added comment for background. This change is necessary to avoid breaking downstream users once rust-lang/rust#119820 lands. While the exact impact is uncertain, we know https://github.com/grego/blades to be affected.

Please ask for clarification if you would like further information. It is likely desirable to remove the parameter S from Ramhorms::get, always requiring str. This would require a new major version however. I apologize for the inconvenience.

@maciejhirsz
Copy link
Owner

Thanks for bringing this up! I'll go ahead with your suggestion and just require &str, it seems more idiomatic and less hacky of a solution to me.

Ramhorns can use a 1.0 release since it's been quite stable for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants