Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is reverting
ListProduct
storage toVec<Box<_>>
fromPageList
(see https://maciej.codes/2023-04-28-optimizing-kobold.html).I managed to keep this implementation relatively light on Wasm size compared to my initial one. To implement keyed lists and finally getting Kobold up on the js-framework-benchmark the individual list items need to have their own stable pointers. Even though this might introduce some memory fragmentation, it should also improve things slightly since iteration over the list cannot be simpler.
There is also some room for optimization for "flat" array-backed lists that are bounded to some
const N: usize
length.