Fix conversion for characters with vowel ü (v)

lxyu · Oct 8, 2016 · 287e34a · 287e34a
1 parent 4dbd542
commit 287e34a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/pinyin/pinyin.py b/pinyin/pinyin.py
@@ -37,7 +37,7 @@ def _pinyin_generator(chars, format):
         elif format == "diacritical":
             # Find first vowel -- where we should put the diacritical mark
             vowels = itertools.chain((c for c in pinyin if c in "aeo"),
-                                     (c for c in pinyin if c in "iu"))
+                                     (c for c in pinyin if c in "iuv"))
             vowel = pinyin.index(next(vowels)) + 1
             pinyin = pinyin[:vowel] + tonemarks[tone] + pinyin[vowel:]
         else:

diff --git a/test_pinyin.py b/test_pinyin.py
@@ -20,6 +20,7 @@ def test_get(self):
 
         self.assertEqual(pinyin.get('你好'), u('nǐhǎo'))
         self.assertEqual(pinyin.get('叶'), u('yè'))
+        self.assertEqual(pinyin.get('少女'), u('shǎonv̌'))
 
     def test_get_with_delimiter(self):
         self.assertEqual(pinyin.get('你好', " "), u('nǐ hǎo'))
@@ -46,6 +47,7 @@ def test_correct_diacritical(self):
         self.assertEqual(pinyin.get("小"), u("xiǎo"))
         self.assertEqual(pinyin.get("绝"), u("jué"))
         self.assertEqual(pinyin.get("被"), u("bèi"))
+        self.assertEqual(pinyin.get("略"), u("lvè"))
 
 
 if __name__ == '__main__':