Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore validation with JSON Schema #65

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

lucacorti
Copy link
Owner

This is more of a POC to see if we can easily add validation by extending resource attributes and leveraging JSON Schema to do the heavy lifting. What do you think?

@lucacorti lucacorti requested a review from treere February 6, 2024 20:14
@lucacorti lucacorti force-pushed the feature/validation branch from 3e7d27c to 5b49569 Compare June 6, 2024 18:58
@treere
Copy link
Collaborator

treere commented Jun 6, 2024

It looks good. If I'm reading it correctly with this validation step this library can validate the params itself without any other library doing the job.

@lucacorti
Copy link
Owner Author

Yes, that's the idea. This is just a POC:

  • The resource definition can be expanded to support more features from json schema.
  • We could work out a way to collect everything and generate a reasonable OpenAPI specification.
  • We can also experiment with different libraries to see what fits best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants