DM-48838: Create Gafaelfawr tokens in parallel #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a flock, create the Gafaelfawr tokens in parallel (up to the limit of the httpx connection pool, which is 100) instead of serially. No business is using the shared global httpx client and connection pool, so remove it from the constructors of all of the business classes and stop passing it down. The Nublado business uses a separate connection pool per monkey maintained in the Nublado client, and the TAP business uses pyvo, which manages its own connections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a flock, create the Gafaelfawr tokens in parallel (up to the limit of the httpx connection pool, which is 100) instead of serially.
No business is using the shared global httpx client and connection pool, so remove it from the constructors of all of the business classes and stop passing it down. The Nublado business uses a separate connection pool per monkey maintained in the Nublado client, and the TAP business uses pyvo, which manages its own connections.