refactor: reuse read_serial fn with nusb #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droidmonkey
approved these changes
Sep 9, 2024
| let challenge = [0; CHALLENGE_SIZE]; | ||
| let command = Command::DeviceSerial; | ||
|
|
||
| let d = Frame::new(challenge, command); // FIXME: do not need a challange |
There was a problem hiding this comment.
I guess now would be a good time to fix this?
There was a problem hiding this comment.
I'm not exactly sure how, so I'll have to handle this later. At least now we only have to fix this in one place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the
serial_number()function will not populate the serial number on the devices when using thenusbbackend, so this PR moves theread_serial_from_devicefunction to the genericBackendimplementation, and reuses it in thenusbbackend.I also noticed that the top-level
read_serial_numberand theread_serial_from_devicefunctions were exactly the same except for the interface, so we're now reusing the backend to serve the request instead of duplicating the code.